Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export COQ_IMAGE #89

Merged
merged 1 commit into from
May 10, 2024
Merged

export COQ_IMAGE #89

merged 1 commit into from
May 10, 2024

Conversation

JasonGross
Copy link
Member

This should allow users who want to access COQ_IMAGE to access it by adding COQ_IMAGE to the export: list.

@JasonGross
export COQ_IMAGE
d7a5c76 
This should allow users who want to access `COQ_IMAGE` to access it by adding `COQ_IMAGE` to the `export:` list.
@JasonGross
Copy link
Member Author

The build issue

# File "src/coq_elpi_builtins.ml", line 1947, characters 39-44:
  # 1947 |        let cinfo = Declare.CInfo.make ?using ~name:(Id.of_string id) ~typ:types ~impargs:[] () in
  #                                               ^^^^^
  # Error: The function applied to this argument has type
  #          ?args:Names.Name.t list -> 'a Declare.CInfo.t
  # This argument cannot be applied with label ?using
  # make[1]: *** [Makefile.coq:730: src/coq_elpi_builtins.cmo] Error 2

is unrelated to this PR

This was referenced May 9, 2024
Closed
Merged
@erikmd
Copy link
Member

erikmd commented May 10, 2024

This should allow users who want to access COQ_IMAGE to access it by adding COQ_IMAGE to the export: list.

LGTM, thanks!

The build issue is unrelated to this PR

Yes, I'll look into this later

@erikmd erikmd merged commit fa005f5 into master May 10, 2024
18 of 20 checks passed
@erikmd erikmd deleted the export-coq-image branch May 10, 2024 06:24
@erikmd erikmd self-assigned this May 10, 2024
@erikmd erikmd added the enhancement New feature or request label May 10, 2024
@JasonGross JasonGross mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erikmd erikmd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGross @erikmd